Re: make VALIDATE domain constraint lock on related relations as ShareUpdateExclusiveLock

From: wenhui qiu <qiuwenhuifx(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: make VALIDATE domain constraint lock on related relations as ShareUpdateExclusiveLock
Date: 2025-05-13 09:34:33
Message-ID: CAGjGUAJjV=6JY9cZ_JwonKrOMtRfcwKZ-a1jLF=UJ2xD9yan5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

HI
Thanks for the patch! and overall this is a valuable improvement in
terms of concurrency and consistency with table-level behavior.The
refactoring to pass LOCK MODE into validateDomainCheckConstraint() improves
flexibility and clarity. and the patch also looks good to me.

Regards

On Tue, May 13, 2025 at 2:23 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:

> On Tue, May 13, 2025 at 8:57 AM jian he <jian(dot)universality(at)gmail(dot)com>
> wrote:
> >
> > hi.
> >
> > We can still perform DML operations on a table while validating its
> > check constraint.
> > Similarly, it should be fine to do DML while validating domain
> constraints?
> > but currently, it's not allowed for domain constraints.
> >
> > The attached patch addresses this problem.
>
> This makes sense, and the patch also looks good to me.
>
> --
> Regards,
> Dilip Kumar
> EnterpriseDB: http://www.enterprisedb.com
>
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2025-05-13 09:49:02 Re: Vacuum statistics
Previous Message Richard Guo 2025-05-13 08:02:54 Add explicit initialization for all PlannerGlobal fields