| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeremy Schneider <schneider(at)ardentperf(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: improving handling of FPIs during recovery prefetching |
| Date: | 2026-10-31 04:58:04 |
| Message-ID: | CAGRkXqR63juzTPovFYi-yVqCO0HU5D3H=pWWtHC=mssBnZ_sOw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tomas,
I did not find a problem. Everything looks correct.
Two small things
1. There is no test for skip_fpi, so I attached a small TAP test.
2. XLogPrefetcherAddFPI() is called when has_image is
set. Maybe call it when this is true instead:
block->apply_image || (block->flags & BKPBLOCK_WILL_INIT)
Redo does not read the page in either case.
Thanks,
Shihao
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-skip_fpi-test.diff.txt | text/plain | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Roman Khapov | 2026-10-31 06:54:32 | Print latency percentiles in pgbench |
| Previous Message | shihao zhong | 2026-10-31 04:47:02 | Re: Proposal: Conflict log history table for Logical Replication |