| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixes inconsistent behavior in vacuum when it processes multiple relations |
| Date: | 2025-06-20 15:54:07 |
| Message-ID: | CAGRkXqQ1gA4rxd-o2uFq1+GDJZOHg+sWMVynUo+S=eDSU-502w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> It's a bit odd that we have both `VacuumParams *params` and
>> `struct VacuumParams *params`.
Thanks for pointing that out, the attached new version fixed that.
>> I'd suggest just marking the VacuumParams *params with const...
I initially considered that approach. However, the current code path
for vacuum_rel handles table option re-consolidation, rather than the
ExecVacuum caller. This would require moving all parameter checks into
ExecVacuum, which I'm not sure is ideal. For this patch, let's focus
on resolving the inconsistent behavior. We can discuss parameter
re-consolidation further in this thread:
https://postgr.es/m/aFRxC1W_kZU9OjJ9%40nathan
| Attachment | Content-Type | Size |
|---|---|---|
| vacuum_tables_options_5.patch | application/octet-stream | 30.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2025-06-20 16:00:38 | Re: Removing rm regress.def |
| Previous Message | Maxim Orlov | 2025-06-20 15:45:28 | mxid and mxoff wraparound issues in pg_upgrade |