| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Date: | 2023-07-18 09:03:38 |
| Message-ID: | CAGPVpCT-Ep-m=XyWOZWKJSZdEa20X44YEJKdJ9szry8ZiMzbag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
Peter Smith <smithpb2250(at)gmail(dot)com>, 18 Tem 2023 Sal, 04:33 tarihinde şunu
yazdı:
> On Tue, Jul 18, 2023 at 11:25 AM Peter Smith <smithpb2250(at)gmail(dot)com>
> wrote:
> >
> > On Tue, Jul 18, 2023 at 1:54 AM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
> wrote:
> > >
> > > Hi,
> > >
> > > PFA updated patches. Rebased 0003 with minor changes. Addressed
> Peter's reviews for 0001 and 0002 with some small comments below.
> > >
> >
> > Thanks, I will take another look at these soon. FYI, the 0001 patch
> > does not apply cleanly. It needs to be rebased again because
> > get_worker_name() function was recently removed from HEAD.
> >
>
> Sorry, to be more correct -- it applied OK, but failed to build.
>
Attached the fixed patchset.
Thanks,
--
Melih Mutlu
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v20-0001-Refactor-to-split-Apply-and-Tablesync-Workers.patch | application/octet-stream | 25.6 KB |
| v20-0002-Reuse-Tablesync-Workers.patch | application/octet-stream | 10.5 KB |
| v20-0003-Reuse-connection-when-tablesync-workers-change-t.patch | application/octet-stream | 6.7 KB |
| v20-0004-Add-replication-protocol-cmd-to-create-a-snapsho.patch | application/octet-stream | 21.1 KB |
| v20-0005-Reuse-Replication-Slot-and-Origin-in-Tablesync.patch | application/octet-stream | 55.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-07-18 09:06:51 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Thom Brown | 2023-07-18 08:36:55 | Re: generic plans and "initial" pruning |