| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-14 11:01:56 |
| Message-ID: | CAGPVpCSb7gE+9LLSkt7zU_jVo9_qRuv9jOESWWkG9ZauvCgamw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Attached v13.
Peter Smith <smithpb2250(at)gmail(dot)com>, 14 Mar 2023 Sal, 03:07 tarihinde şunu
yazdı:
> Here are some review comments for patch v12-0001
>
Thanks for reviewing. I tried to make explanations in docs better
according to your comments.
What do you think?
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, 14 Mar 2023 Sal, 06:17 tarihinde
şunu yazdı:
> I think it would better to write the tests for this feature in the
> existing test file 014_binary as that would save some time for node
> setup/shutdown and also that would be a more appropriate place for
> these tests.
I removed 032_binary_copy.pl and added those tests into 014_binary.pl.
Also added the case with different column order as Peter suggested.
Best,
--
Melih Mutlu
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-Allow-logical-replication-to-copy-table-in-binary.patch | application/octet-stream | 14.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | gkokolatos | 2023-03-14 11:07:25 | Re: Add LZ4 compression in pg_dump |
| Previous Message | Gilles Darold | 2023-03-14 10:44:59 | Re: [Proposal] Allow pg_dump to include all child tables with the root table |