Re: Add RANGE with values and exclusions clauses to the Window Functions

From: Oliver Ford <ojford(at)gmail(dot)com>
To: Erikjan Rijkers <er(at)xs4all(dot)nl>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add RANGE with values and exclusions clauses to the Window Functions
Date: 2017-11-27 12:06:35
Message-ID: CAGMVOdsopg5ZAuJh9+ceq-s0pU2qqZsZn-jbL4A1c=h1iWaZVA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 24, 2017 at 3:08 PM, Erikjan Rijkers <er(at)xs4all(dot)nl> wrote:
> SELECT pg_get_viewdef('v_window');
> ! pg_get_viewdef
> ! ----------------------------------------------
> ! SELECT i.i, +
> ! sum(i.i) OVER (ORDER BY i.i) AS sum_rows+
> FROM generate_series(1, 10) i(i);
> (1 row)
>
> --- 1034,1043 ----
> (10 rows)
>
> SELECT pg_get_viewdef('v_window');
> ! pg_get_viewdef
> !
> ---------------------------------------------------------------------------------------
> ! SELECT i.i,
> +
> ! sum(i.i) OVER (ORDER BY i.i ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING)
> AS sum_rows+
> FROM generate_series(1, 10) i(i);
> (1 row)
>
>
> This small hickup didn't prevent building an instance but obviously I
> haven't done any real tests yet.
>
>
> thanks,
>
>
> Erik Rijkers

After another clone and rebuild it works alright with the correct
spacing on mine, so the attached v2 should all pass. I noticed that I
hadn't added the exclusions clauses to the view defs code, so that's
also in this patch with extra tests to cover it.

Attachment Content-Type Size
0001-window-frame-v2.patch application/octet-stream 79.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Glapa 2017-11-27 12:13:32 Re: ERROR: too many dynamic shared memory segments
Previous Message Amit Kapila 2017-11-27 11:54:49 Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com