Re: Add trim_trailing_whitespace to editorconfig file

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add trim_trailing_whitespace to editorconfig file
Date: 2024-02-15 09:26:34
Message-ID: CAGECzQTOZ+RbbKwLS9C3vwULsbxzyqgRru7fm4edoAUgZqVNTQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 14 Feb 2024 at 23:19, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > +1 from me. But when do we want it to be false? That is, why not
> > declare it true for all file types?
>
> Regression test .out files commonly have spaces at the end of the line. (Not
> to mention the ECPG .c files but they probably really shouldn't have.)

Attached is v2, which now makes the rules between gitattributes and
editorconfig completely identical. As well as improving two minor
things about .gitattributes before doing that.

Attachment Content-Type Size
v2-0002-Require-final-newline-in-.po-files.patch application/octet-stream 2.0 KB
v2-0003-Bring-editorconfig-in-line-with-gitattributes.patch application/octet-stream 2.6 KB
v2-0004-Add-note-about-keeping-.editorconfig-and-.gitattr.patch application/octet-stream 1.1 KB
v2-0001-Remove-non-existing-file-from-.gitattributes.patch application/octet-stream 873 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amul Sul 2024-02-15 09:35:06 Re: Add system identifier to backup manifest
Previous Message Amit Kapila 2024-02-15 09:19:54 Re: Synchronizing slots from primary to standby