| From: | Jelte Fennema <me(at)jeltef(dot)nl> |
|---|---|
| To: | Tristen Raab <tristen(dot)raab(at)highgo(dot)ca> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Jelte Fennema <github-tech(at)jeltef(dot)nl> |
| Subject: | Re: Allow specifying a dbname in pg_basebackup connection string |
| Date: | 2023-08-29 13:55:05 |
| Message-ID: | CAGECzQTEXbhQYOhxWAiGWqc-Ec_av1qi688kyDTkpyALUidSVQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 28 Aug 2023 at 23:50, Tristen Raab <tristen(dot)raab(at)highgo(dot)ca> wrote:
> I've reviewed your patch and it applies and builds without error. When testing this patch I was slightly confused as to what its purpose was, after testing it I now understand. Initially, I thought this was a change to add database-level replication. I would suggest some clarifications to the documentation such as changing:
Thanks for the review. I've updated the documentation to make it
clearer (using some of your suggestions but also some others)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Allow-specifying-a-dbname-in-pg_basebackup-connec.patch | application/octet-stream | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-08-29 14:01:47 | Re: Wrong usage of pqMsg_Close message code? |
| Previous Message | Noah Misch | 2023-08-29 13:49:26 | Re: Query execution in Perl TAP tests needs work |