| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tristan Partin <tristan(at)neon(dot)tech>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Subject: | Re: psql not responding to SIGINT upon db reconnection |
| Date: | 2024-04-03 13:32:39 |
| Message-ID: | CAGECzQRmbNRz4hQ8JhbopAZLgAg_cQyT+zPxq4u9-kEHXqyXJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2 Apr 2024 at 16:33, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Committed it, I did. My thanks for working on this issue, I extend.
Looking at the committed version of this patch, the pg_unreachable
calls seemed weird to me. 1 is actually incorrect, thus possibly
resulting in undefined behaviour. And for the other call an imho
better fix would be to remove the now 21 year unused enum variant,
instead of introducing its only reference in the whole codebase.
Attached are two trivial patches, feel free to remove both of the
pg_unreachable calls.
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0002-Remove-PGRES_POLLING_ACTIVE.patch | text/x-patch | 1.4 KB |
| v11-0001-Fix-actually-reachable-pg_unreachable-call.patch | text/x-patch | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2024-04-03 13:39:33 | Re: pg_combinebackup --copy-file-range |
| Previous Message | Bruce Momjian | 2024-04-03 13:26:34 | Re: [PATCH] Modify pg_ctl to detect presence of geek user |