| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [EXTERNAL] Re: Add non-blocking version of PQcancel |
| Date: | 2024-02-02 14:03:39 |
| Message-ID: | CAGECzQRiRGPGnotCdXR_Wh2iJr+JkXwA3jA_OxseNa2ufOSMvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2 Feb 2024 at 13:19, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Thank you, looks good.
>
> I propose the following minor/trivial fixes over your initial 3 patches.
All of those seem good like fixes. Attached is an updated patchset
where they are all applied. As well as adding a missing word ("been")
in a comment that I noticed while reading your fixes.
| Attachment | Content-Type | Size |
|---|---|---|
| v30-0003-libpq-Change-some-static-functions-to-extern.patch | text/x-patch | 9.7 KB |
| v30-0004-Add-non-blocking-version-of-PQcancel.patch | text/x-patch | 43.1 KB |
| v30-0002-libpq-Add-pqReleaseConnHosts-function.patch | text/x-patch | 2.5 KB |
| v30-0005-Start-using-new-libpq-cancel-APIs.patch | text/x-patch | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-02-02 15:05:56 | Re: [EXTERNAL] Re: Add non-blocking version of PQcancel |
| Previous Message | Heikki Linnakangas | 2024-02-02 13:52:50 | Re: XLog size reductions: smaller XLRec block header for PG17 |