Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

From: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Burroughs <jburroughs(at)instructure(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dave Cramer <davecramer(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs
Date: 2024-03-08 11:47:15
Message-ID: CAGECzQRbjxi72uY_b7MQaqG=YnDRvpo5imDniPtZsufj8WahTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fixed some conflicts again.

To summarize the current state of this patchset, it consists of 5
different parts that could be merged separately:
1. 0001-0005 are needed for any protocol change, and hopefully
shouldn't require much discussion
2. 0006-0009 introduce a new protocol message that can be used to
update GUCs. I think we might want some discussion on the design of
the protocol message, but I think the behaviour has all feedback
incorporated.
3. 0010 Adds GUC contexts for protocol extensions, in the way that Tom
Lane suggested.
4. 0011 Adds a way to mark some GUCs as only changeable using protocol
messages, there's still some discussion needed on this (I can remove
this from the patchset if that makes it easier).
5. 0012 Adds some additional tests for some of the previous features
6. 0013 Add a protocol parameter to control which GUCs have
GUC_REPORT. Quite straightforward imho.

Attachment Content-Type Size
v10-0005-libpq-Include-minor-version-number-in-PQprotocol.patch application/octet-stream 3.3 KB
v10-0004-Prepare-server-code-for-addition-of-protocol-ext.patch application/octet-stream 2.0 KB
v10-0003-libpq-Add-PQunsupportedProtocolExtensionParamete.patch application/octet-stream 4.1 KB
v10-0001-libpq-Remove-instance-of-hardcoded-protocol-vers.patch application/octet-stream 1.1 KB
v10-0002-libpq-Handle-NegotiateProtocolVersion-message-mo.patch application/octet-stream 5.8 KB
v10-0007-Add-protocol-message-to-change-parameters.patch application/octet-stream 16.3 KB
v10-0008-psql-Add-parameterset-meta-command.patch application/octet-stream 8.1 KB
v10-0006-Bump-protocol-version-to-3.1.patch application/octet-stream 1015 bytes
v10-0009-psql-Warn-about-unsupported-protocol-features.patch application/octet-stream 2.3 KB
v10-0010-Add-GUC-contexts-for-protocol-extensions.patch application/octet-stream 5.9 KB
v10-0012-Add-tests-for-ParameterSet-and-_pq_.protocol_man.patch application/octet-stream 24.5 KB
v10-0013-Add-_pq_.report_parameters-protocol-extension.patch application/octet-stream 23.5 KB
v10-0011-Add-_pq_.protocol_managed_params-protocol-extens.patch application/octet-stream 11.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2024-03-08 11:53:14 Re: a wrong index choose when statistics is out of date
Previous Message Jelte Fennema-Nio 2024-03-08 11:25:28 Re: Support a wildcard in backtrace_functions