Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Date: 2023-12-20 13:46:52
Message-ID: CAGECzQQ-U7yjxHjec901qTFgV56nSphMYhYg0wH0e+KOq3cZ6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 14 Dec 2023 at 13:57, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
> I changed all the places that were not adhering to those spellings.

It seems I forgot a /g on my sed command to do this so it turned out I
missed one that caused the test to fail to compile... Attached is a
fixed version.

I also updated the patchset to use the EOF detection provided by
0a5c46a7a488f2f4260a90843bb9de6c584c7f4e instead of introducing a new
way of EOF detection using a -2 return value.

Attachment Content-Type Size
v24-0003-Start-using-new-libpq-cancel-APIs.patch application/octet-stream 10.5 KB
v24-0001-Fix-spelling-of-canceled-cancellation.patch application/octet-stream 3.1 KB
v24-0002-Add-non-blocking-version-of-PQcancel.patch application/octet-stream 43.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2023-12-20 13:49:53 Re: backtrace_on_internal_error
Previous Message Daniel Gustafsson 2023-12-20 13:31:41 Re: Remove MSVC scripts from the tree