Re: Weird code in pgDomain.cpp

On Sun, Apr 8, 2012 at 3:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> > Hi,
> >
> > I was trying to fix a bug on dlgDomain, and I found this code (in
> > pgadmin/schema/pgDomain.cpp):
> >
> > wxString conname = set->GetVal(wxT("conname"));
> > if (!conname.StartsWith(wxT("$")))
> > check += wxT("CONSTRAINT ") + qtIdent(conname) + wxT(" ");
> >
> > I'm wondering why we look for a dollar sign in the first character of a
> > check constraint in a domain. It means nothing to me. Could it be some
> > GreenPlum or EnterpriseDB specific code? or is it something else?
>
> Not that I recall - Ashesh, Sachin - do you know if it's a PPAS thing?
>
Not that I recall.

It's been there from very long time..
i.e. git log 6003c502d89900b2b2e1538d340db028b1880aa1 -p -n 1
schema/pgDomain.cpp

--
Ashesh Vashi

>
> >
> > I'm also wondering if we could drop this code. Doesn't seem to do much,
> > and doesn't help us with modifying a check constraint in a domain.
>
> Dunno.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>