| From: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] psql: Complete INDEX after REPACK USING |
| Date: | 2026-11-08 22:23:05 |
| Message-ID: | CAG7L5+5Na_OcpYf-JPdn=9Q-p0_Q1YtdtvkM7eP0+rnC02x3Dw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
After manually typing `REPACK USING ` and pressing Tab, psql inserts
another `USING INDEX`, producing `REPACK USING USING INDEX`. After an
explicit table name, `REPACK tab1 USING ` offers no completion.
The attached fix completes `INDEX` after `USING`, with or without an
option list, table name, or column list.
Regression tests are attached as a separate patch.
I tested on master with assertions enabled. The new tests fail without
the fix, and all psql TAP tests pass with it.
I have also posted a separate fix for index completion after a
`REPACK` column list [1]. The two fixes are independent.
Thanks,
Sho
--
=======================================
*Sho Ito (Sean)*
E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-psql-Complete-INDEX-after-REPACK-USING.patch | application/octet-stream | 1.3 KB |
| v1-0001-psql-Test-completion-after-REPACK-USING.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Sho Ito | 2026-11-08 22:12:39 | [PATCH] psql: Fix REPACK index completion after a column list |