| From: | Mario González Troncoso <gonzalemario(at)gmail(dot)com> |
|---|---|
| To: | Florin Irion <irionr(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql tab completion for user functions and if explicitly required also "pg_" |
| Date: | 2026-06-30 20:54:02 |
| Message-ID: | CAFsReFWqgQSJ3BN8Fd4z-yTBLzNrYSZinAabqOoffhuq_mEzKQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 30 Jun 2026 at 14:28, Mario González Troncoso
<gonzalemario(at)gmail(dot)com> wrote:
>
>
> It needed a rebase. Also, the patch didn't apply directly, I fixed the
> offset and there was a corruption in the file I couldn't fix.
>
> $ git am ~/Downloads/v1-0001-Add-function-name-tab-completion-after-SELECT-in-.patch
> Applying: Add function name tab completion after SELECT in psql
> error: corrupt patch at line 30
> Patch failed at line 30.
>
> In the end, after I fixed the offset, I applied the commit by hand,
> committed the change and squashed it into a single commit to produce
> the patch again.
> Let me know please if you find any errors. I'll check into the code
> now, this was my first attempt to only rebase into latest changes and
> make cfboot hopefully happy.
>
> >
I noticed a syntax error and the change was passing the local tests
because I didn't enable the TAP tests. Fixing the syntax error I
introduced and passing the tests locally, this time with TAP tests
enabled.
--
Mario Gonzalez
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-function-name-tab-completion-after-SELECT-in-.patch | text/x-patch | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2026-06-30 21:18:58 | Re: Improving display of octal GUCs |
| Previous Message | Erik Wienhold | 2026-06-30 20:34:55 | Re: Fix psql pager selection for wrapped expanded output |