Re: Reporting planning time with EXPLAIN

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reporting planning time with EXPLAIN
Date: 2017-03-09 05:44:04
Message-ID: CAFjFpRfbwONMqKYfPAuLVsG4YpjbR=BD_ToyKoLUGNDgxm-KJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 9, 2017 at 2:58 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Ashutosh,
>
> * Ashutosh Bapat (ashutosh(dot)bapat(at)enterprisedb(dot)com) wrote:
>> On Tue, Mar 7, 2017 at 9:23 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>> > I'm going through these with an eye towards committing them soon. I've
>> > already adjusted some of the documentation and comments per our earlier
>> > discussion
>>
>> Thanks a lot.
>
> I've pushed this with the editorialization of the documentation which
> we discussed up-thread along with some improvements to the comments
> along with your latest variable name suggestions and changes as
> discussed.

The documentation looks pretty good and comment changes look good too.
The way those two have been phrased, it's easy to understand the
defaults for SUMMARY, which otherwise could have been confusing. The
test looks good too.

Thanks for all the improvements.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-03-09 06:19:21 Re: foreign partition DDL regression tests
Previous Message Ashutosh Bapat 2017-03-09 05:31:13 Re: PATCH: psql show index with type info