Re: Push down more full joins in postgres_fdw

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Push down more full joins in postgres_fdw
Date: 2016-10-22 16:46:10
Message-ID: CAFjFpRfZxcCaX6jO0T7DH6K6t8dcxzpznkgAju=uTp+cOWtk=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> 11. I have reworded following comment and restructured the code that follows it
> in the attached patch.
> + /*
> + * Set the subquery information. If the relation performs a full outer
> + * join and if the input relations have non-NIL remote_conds, the input
> + * relations need to be deparsed as a subquery.
> + */
> The code esp. the if .. else .. block followed by another one, made it a bit
> unreadable. Hence I restructured it so that it's readable and doesn't require
> variable "relids" from earlier code, which was being reused. Let me know if
> this change looks good.
>
Sorry, forgot to attach the patch. Here it is.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Attachment Content-Type Size
subquery_deparse_fulljoin_restructure.patch text/x-diff 87.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-10-22 17:13:06 Re: emergency outage requiring database restart
Previous Message Tom Lane 2016-10-22 16:38:47 Re: On conflict update & hint bits