| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Generic type subscripting |
| Date: | 2020-09-28 09:39:34 |
| Message-ID: | CAFj8pRDcrTGQ5LWooj5qAXGEAjXp3gvWE9ZuBek4fn=yRN6+uw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
po 28. 9. 2020 v 11:36 odesílatel Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
napsal:
> > On Fri, Sep 25, 2020 at 06:43:38PM +0200, Pavel Stehule wrote:
> >
> > I checked this set of patches and it looks well.
> >
> > I have only one minor comment. I understand the error message, but I am
> not
> > sure if without deeper knowledge I can understand.
> >
> > +update test_jsonb_subscript set test_json[-8] = 1;
> > +ERROR: path element at position 1 is out of range: -8
> >
> > Maybe 'value of subscript "-8" is out of range'. Current error message is
> > fully correct - but people probably have to think "what is a path element
> > at position 1?" It doesn't look intuitive.
> >
> > Do you have some idea?
>
> Interesting question. I've borrowed this error message format from other
> parts of setPath function where it appears couple of times and
> unfortunately can't suggest anything better. In case it this patch will
> get lucky enough to attract someone else, maybe we can leave it to a
> committer, what do you think?
>
ok
> > My comment is minor, and I mark this patch with pleasure as ready for
> > committer.
> >
> > patching and compiling - without problems
> > implemented functionality - I like it
> > Building doc - without problems
> > make check-world - passed
>
> Thanks!
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2020-09-28 10:28:03 | Re: Parallel Inserts in CREATE TABLE AS |
| Previous Message | Dmitry Dolgov | 2020-09-28 09:36:31 | Re: [HACKERS] [PATCH] Generic type subscripting |