Re: Schema variables - new implementation for Postgres 15

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Joel Jacobson <joel(at)compiler(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Schema variables - new implementation for Postgres 15
Date: 2022-08-25 17:49:38
Message-ID: CAFj8pRCvyO-MBdCbGmrGPdaE95awKWvV7+14W8N=iz-a_iz8Tw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

> - For sessionvariable.c (in 0002), I see that there are still all the
> comments
> and code about checking type validity based on a generation number and
> other
> heuristics. I still fail to understand why this is needed at all as the
> stored datum should remain compatible as long as we prevent the few
> incompatible DDL that are also prevented when there's a relation
> dependency.
> As an example, I try to quickly disable all that code with the following:
>
>
>
I am sending an alternative implementation based on using own int8 sequence
as protection against unwanted oid equation of different session's
variables.

This code is much shorter, and, I think better, but now, the creating
sequence in bootstrap time is dirty. Maybe instead the sequence can be used
64bite timestamp or some else - it needs a unique combination of oid, 8byte.

Regards

Pavel

Attachment Content-Type Size
v20220825-1-0011-documentation.patch text/x-patch 42.1 KB
v20220825-1-0008-typedefs.patch text/x-patch 1.6 KB
v20220825-1-0010-this-patch-changes-error-message-column-doesn-t-exis.patch text/x-patch 25.2 KB
v20220825-1-0007-possibility-to-dump-session-variables-by-pg_dump.patch text/x-patch 19.5 KB
v20220825-1-0009-regress-tests-for-session-variables.patch text/x-patch 46.9 KB
v20220825-1-0006-enhancing-psql-for-session-variables.patch text/x-patch 15.1 KB
v20220825-1-0005-DISCARD-VARIABLES-command.patch text/x-patch 3.2 KB
v20220825-1-0004-support-of-LET-command-in-PLpgSQL.patch text/x-patch 11.5 KB
v20220825-1-0003-LET-command.patch text/x-patch 39.1 KB
v20220825-1-0002-session-variables.patch text/x-patch 102.7 KB
v20220825-1-0001-catalog-support-for-session-variables.patch text/x-patch 96.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-08-25 18:21:05 Re: SYSTEM_USER reserved word implementation
Previous Message Ranier Vilela 2022-08-25 17:49:20 Re: postgres_fdw hint messages