Re: proposal: possibility to read dumped table's name from file

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: possibility to read dumped table's name from file
Date: 2020-07-06 04:34:15
Message-ID: CAFj8pRCRQOWLm2LrWcbkcm1Dx7yTuLks1_2VrTJO3PARDNXO3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

ne 5. 7. 2020 v 22:37 odesílatel Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
napsal:

>
>
> ne 5. 7. 2020 v 22:31 odesílatel Justin Pryzby <pryzby(at)telsasoft(dot)com>
> napsal:
>
>> On Wed, Jul 01, 2020 at 04:24:52PM -0500, Justin Pryzby wrote:
>> > On Thu, Jun 11, 2020 at 09:36:18AM +0200, Pavel Stehule wrote:
>> > > st 10. 6. 2020 v 0:30 odesílatel Justin Pryzby <pryzby(at)telsasoft(dot)com>
>> napsal:
>> > > > > + /* ignore empty
>> rows */
>> > > > > + if (*line != '\0')
>> > > >
>> > > > Maybe: if line=='\0': continue
>> > > > We should also support comments.
>> >
>> > Comment support is still missing but easily added :)
>>
>> Still missing from the latest patch.
>>
>
> I can implement a comment support. But I am not sure about the format. The
> start can be "--" or classic #.
>
> but "--" can be in this context messy
>

here is support for comment's line - first char should be #

Regards

Pavel

>
>
>> With some added documentation, I think this can be RfC.
>>
>> --
>> Justin
>>
>

Attachment Content-Type Size
pg_dump-filter-20200706.patch text/x-patch 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-07-06 05:01:29 "tuple concurrently updated" in pg_restore --jobs
Previous Message Bharath Rupireddy 2020-07-06 04:27:31 Re: Cleanup - adjust the code crossing 80-column window limit