|From:||Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>|
|To:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|Cc:||Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: patch: function xmltable|
|Views:||Raw Message | Whole Thread | Download mbox|
2016-12-07 18:34 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Pavel Stehule wrote:
> > I fixed two issues.
> > 2. there was reverse setting in NOT NULL flag
> Ah-hah, that was silly, thanks.
> > 1. there are not columns data when there are not any explicit column -
> Hmm. Now that I see how this works, by having the GetValue "guess" what
> is going on and have a special case for it, I actually don't like it
> very much. It seems way too magical. I think we should do away with
> the "if column is NULL" case in GetValue, and instead inject a column
> during transformTableExpr if columns is NIL. This has implications on
> ExecInitExpr too, which currently checks for an empty column list -- it
> would no longer have to do so.
I prefer this way against second described. The implementation should be in
table builder routines, not in executor.
sending new update
> Maybe this means we need an additional method, which would request "the
> expr that returns the whole row", so that transformExpr can work for
> XmlTable (which I think would be something like "./") and the future
> JsonTable stuff (I don't know how that one would work, but I assume it's
> not necessarily the same thing).
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Alvaro Herrera||2016-12-07 19:50:49||Re: patch: function xmltable|
|Previous Message||Joseph Brenner||2016-12-07 18:58:56||Re: [GENERAL] Select works only when connected from login postgres|