Re: Add support for SRF and returning composites to pl/tcl

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add support for SRF and returning composites to pl/tcl
Date: 2016-11-05 20:39:47
Message-ID: CAFj8pRBetRPrs7gu9r303Epx1NMJZ9VUgVLnRDk7yU4CV4bGsg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

I checked this code, and it looks well

0. there are not any reason why we would not to implement this feature -
more, the implementation is simple.

1. there was not problem with patching, compilation
2. the original patch is missing new expected result for regress tests,
fixed in attached patch
3. all regress tests passed
4. the tests and docs is enough for this purpose

I'll mark this patch as ready for commit

Regards

Pavel

2016-10-13 0:06 GMT+02:00 Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>:

> Attached is a patch that adds support for SRFs and returning composites
> from pl/tcl. This work was sponsored by Flight Aware.
> --
> Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
> Experts in Analytics, Data Architecture and PostgreSQL
> Data in Trouble? Get it in Treble! http://BlueTreble.com
> 855-TREBLE2 (855-873-2532) mobile: 512-569-9461
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>

Attachment Content-Type Size
pltcl_srf_composite2.diff text/plain 23.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-11-06 01:12:20 Re: Add support for SRF and returning composites to pl/tcl
Previous Message Tom Lane 2016-11-05 20:05:34 Re: Mention column name in error messages