Skip site navigation (1) Skip section navigation (2)

Re: patch: function xmltable

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: function xmltable
Date: 2017-02-20 18:12:55
Message-ID: CAFj8pRBYzyGLNq7rmbrE=Jx60ku6yEdtNRwojN9qPmLvcSJFxQ@mail.gmail.com (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
Hi

2017-02-16 6:38 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:

> Hi
>
>
>> please see attached patch
>>
>> * enhanced regress tests
>> * clean memory context work
>>
>
> new update
>
> fix a bug in string compare
> fix some typo and obsolete comments
>
> Regards
>

some minor but interesting fix.

I found so some xml values imported via recv function can have
inconsistency between header encoding and used encoding. Internally the
header encoding is removed - see xml_out function.

So now, when I have to prepare data for libxml2, I don't do direct cast,
but I use xml_out_internal instead. Maybe this technique should be used
elsewhere? Same issue I see on xpath function.

Solved issue is not too often probably - the some different encoding than
utf8 should be used in XML document and XML document should be loaded with
recv function.

Regards

Pavel



>
> Pavel
>
>
>>
>> Regards
>>
>> Pavel
>>
>>
>>>
>>> --
>>> Álvaro Herrera                https://www.2ndQuadrant.com/
>>> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>>>
>>
>>
>

Attachment: xmltable-44.patch
Description: text/x-patch (231.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Masahiko SawadaDate: 2017-02-20 18:14:01
Subject: Re: GUC for cleanup indexes threshold.
Previous:From: Simon RiggsDate: 2017-02-20 17:56:33
Subject: Re: Should we cacheline align PGXACT?

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group