2017-01-11 22:53 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Alvaro Herrera wrote:
> > The more I look at this, the less I like using NameArgExpr for
> > namespaces. It looks all wrong to me, and it causes ugly code all over.
> > Maybe I just need to look at it a bit longer.
> I think it'd be cleaner to use ResTarget for the namespaces, like
> xml_attribute_el does, and split the names from actual exprs in the same
> way. So things like ExecInitExpr become simpler because you just
> recurse to initialize the list, without having to examine each element
> individually. tabexprInitialize can just do forboth().
> The main reason I don't like abusing NamedArgExpr is that the whole
> comment that explains it becomes a lie.
I used your proposed way based on Restarget
Updated patch attached.
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
In response to
pgsql-hackers by date
|Next:||From: Peter Eisentraut||Date: 2017-01-12 15:06:51|
|Subject: pg_upgrade vs. pg_ctl stop -m fast|
|Previous:||From: Jesper Pedersen||Date: 2017-01-12 14:38:53|
|Subject: Re: Retiring from the Core Team|