Re: patch: function xmltable

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: function xmltable
Date: 2017-01-12 15:02:07
Message-ID: CAFj8pRBTmHsJ-mU4n75JhuS8-HK1YyDPYF6LQbPd3D1fDwNKXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi

2017-01-11 22:53 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:

> Alvaro Herrera wrote:
>
> > The more I look at this, the less I like using NameArgExpr for
> > namespaces. It looks all wrong to me, and it causes ugly code all over.
> > Maybe I just need to look at it a bit longer.
>
> I think it'd be cleaner to use ResTarget for the namespaces, like
> xml_attribute_el does, and split the names from actual exprs in the same
> way. So things like ExecInitExpr become simpler because you just
> recurse to initialize the list, without having to examine each element
> individually. tabexprInitialize can just do forboth().
>
> The main reason I don't like abusing NamedArgExpr is that the whole
> comment that explains it becomes a lie.
>

I used your proposed way based on Restarget

Updated patch attached.

Regards

Pavel

>
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

Attachment Content-Type Size
xmltable-27.patch text/x-patch 162.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-01-12 15:06:51 pg_upgrade vs. pg_ctl stop -m fast
Previous Message Jesper Pedersen 2017-01-12 14:38:53 Re: Retiring from the Core Team