| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: custom function for converting human readable sizes to bytes |
| Date: | 2015-11-25 04:57:57 |
| Message-ID: | CAFj8pRBRzZDE3=o+s_x_LuB+62LEuZ8iJK59XumtuC=Beb61dw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
2015-11-23 19:47 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Pavel Stehule wrote:
>
> > so pg_size_bytes is good enough for everybody?
>
> That seems good enough to me.
>
> I would have it accept GiB and GB and have both transform to base 2, and
> have an optional boolean flag whose non-default value turns the GB
> interpretation into base 10, leaving the GiB interpretation unaffected.
>
attached proof concept based on parser "parse_int" from guc.c
It works well to 1TB what is enough for memory setting, but too low for
proposed target.
There are two ways
1. enhance the "parse_int"
2. using independent implementation - there is some redundant code, but we
can support duble insted int, and we can support some additional units.
Regards
Pavel
> --
> Álvaro Herrera http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
| Attachment | Content-Type | Size |
|---|---|---|
| pg-size-bytes-poc.patch | text/x-patch | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2015-11-25 05:13:52 | Re: problem with msvc linker - cannot build orafce |
| Previous Message | Craig Ringer | 2015-11-25 03:57:47 | Re: problem with msvc linker - cannot build orafce |