From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Wrong usage of pqMsg_Close message code? |
Date: | 2023-08-28 14:01:29 |
Message-ID: | CAFj8pRBKa2ey+Nm_drj_5Fk-3_zBP7uezP2OrQT1pHeBO7m=6A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
po 28. 8. 2023 v 14:00 odesílatel Aleksander Alekseev <
aleksander(at)timescale(dot)com> napsal:
> Hi Pavel,
>
> > There is message PqMsgClose, but this should be used from client side.
> Here should be used PqMsg_CommandComplete instead?
>
> It seems so. This change was introduced in f4b54e1ed98 [1]:
>
> ```
> --- a/src/backend/tcop/dest.c
> +++ b/src/backend/tcop/dest.c
> @@ -176,7 +176,7 @@ EndCommand(const QueryCompletion *qc, CommandDest
> dest, bool force_undecorated_o
>
> len = BuildQueryCompletionString(completionTag, qc,
>
> force_undecorated_output);
> - pq_putmessage('C', completionTag, len + 1);
> + pq_putmessage(PqMsg_Close, completionTag, len + 1);
>
> case DestNone:
> case DestDebug
> ```
>
> It should have been PqMsg_CommandComplete.
>
> [1]:
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f4b54e1ed98
here is a patch - all tests passed
Regards
Pavel
>
>
> --
> Best regards,
> Aleksander Alekseev
>
Attachment | Content-Type | Size |
---|---|---|
fix_EmdCommandMessage.patch | text/x-patch | 519 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2023-08-28 14:26:29 | Re: Wrong usage of pqMsg_Close message code? |
Previous Message | Melanie Plageman | 2023-08-28 14:00:14 | Re: Eager page freeze criteria clarification |