Re: Re: new set of psql patches for loading (saving) data from (to) text, binary files

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: "Jason O'Donnell" <odonnelljp01(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: new set of psql patches for loading (saving) data from (to) text, binary files
Date: 2017-01-10 15:32:44
Message-ID: CAFj8pRBK60zgHqMiSGaCEHCRVMBZozvh2wEJ8o-aT9J_Y+B4Mw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi

Thank you for review

2017-01-09 17:24 GMT+01:00 Jason O'Donnell <odonnelljp01(at)gmail(dot)com>:

> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: tested, failed
>
> Pavel,
>
> gstore/gbstore:
>
> The functionality worked as expected - one row, one column results of
> queries can be sent to a file or shell. It would be nice if a test case
> was included that proves results more than one row, one column wide will
> fail.
>

fixed

>
> The documentation included is awkward to read. How about:
>
> "Sends the current query input buffer to the server and stores
> the result to an output file specified in the query or pipes the output
> to a shell command. The file or command are written to only if the query
> successfully returns exactly one, non-null row and column. If the
> query fails or does not return data, an error is raised. "
>

super

>
>
> Parameterized Queries:
>
> The functionality proposed works as expected. Throughout the
> documentation, code and test cases the word "Parameterized" is spelled
> incorrectly: "PARAMETRIZED_QUERIES"
>

fixed

>
>
> set_from_file/set_from_bfile:
>
> The functionality proposed worked fine, I was able to set variables in sql
> from files. Minor typo in the documentation:
> "The content is escapeaed as bytea value."
>

fixed

>
> Hope this helps!
>
> Jason O'Donnell
> Crunchy Data
>
> The new status of this patch is: Waiting on Author
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

Attachment Content-Type Size
psql-gstore-02.patch text/x-patch 13.4 KB
psql-parameterized-queries-02.patch text/x-patch 14.4 KB
psql-set-from-file-02.patch text/x-patch 8.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-01-10 15:39:58 Re: pageinspect: Hash index support
Previous Message Robert Haas 2017-01-10 15:22:58 Re: Hash support for grouping sets