| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Joel Jacobson <joel(at)compiler(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Schema variables - new implementation for Postgres 15 |
| Date: | 2022-03-02 05:03:06 |
| Message-ID: | CAFj8pRAoDDDCt1W6jJOGjnfjSYzs_Ei9dN4=RDE+mcVq9hJOhw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
>> + * If this entry was created during the current transaction,
>> + * creating_subid is the ID of the creating subxact; if created in a
>> prior
>> + * transaction, creating_subid is zero.
>>
>> I don't see any place in the code where creating_subid can be zero? It
>> looks
>> like it's only there for future transactional implementation, but for now
>> this
>> attribute seems unnecessary?
>>
>
> The comment is not 100% valid. I removed the sentence about zero value of
> creating_subid.
>
I lost commit with this change. I am sending updated patch.
Regards
Pavel
| Attachment | Content-Type | Size |
|---|---|---|
| v20220302-0002-This-patch-changes-error-message-column-doesn-t-exis.patch | text/x-patch | 29.1 KB |
| v20220302-0001-session-variables.patch | text/x-patch | 325.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-03-02 05:09:16 | Re: Design of pg_stat_subscription_workers vs pgstats |
| Previous Message | Peter Smith | 2022-03-02 04:47:46 | PG DOCS - logical replication filtering |