Re: [HACKERS] plpgsql - additional extra checks

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, nospam-abuse(at)bloodgate(dot)com, David Steele <david(at)pgmasters(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <jim(dot)nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] plpgsql - additional extra checks
Date: 2018-07-25 04:59:00
Message-ID: CAFj8pRAn1gdvxExgzw187X+i3RSOzSOZV=j+Nvo3G2tELbC7HQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Committed, with some minor changes:
>
> 1) The too_many_rows check in exec_stmt_execsql included the errhint
> conditionally, depending on force_error variable
>
> force_error = stmt->strict || stmt->mod_stmt;
> use_errhint = !force_error;
>
> That is, the hint was not included when force_error=true, which does not
> seem quite necessary. Based on off-list discussion with Pavel this was
> unnecessary, so the hint is now included always.
>
> 2) The comment in plpgsql.h still mentioned "compile-time" checks only,
> but the new checks are run-time checks. So tweaked accordingly.
>
> 3) A couple of minor formatting / code style changes.
>

Many thanks

Pavel

>
> regards
>
> --
> Tomas Vondra http://www.2ndQuadrant.com
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2018-07-25 05:42:37 Re: Early WIP/PoC for inlining CTEs
Previous Message Imai, Yoshikazu 2018-07-25 02:53:57 RE: Locking B-tree leafs immediately in exclusive mode