| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal - plpgsql unique statement id |
| Date: | 2019-01-22 18:04:25 |
| Message-ID: | CAFj8pRAn+gnOvN80z7aHumQypLQRARPf7JAfbc9jra5vHatu6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
út 22. 1. 2019 v 14:55 odesílatel Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> napsal:
> There are still a handful of places where a statement is created but no
> stmtid is assigned. Can you check those?
>
> src/pl/plpgsql/src/pl_exec.c:2815
> src/pl/plpgsql/src/pl_exec.c:4580
>
These statements are "fake" very short life statements without processing
via statement switch. Should not be counted, because are dynamically
created, dropped, and stmtid should be 0 or -1 (that means it should be int
again).
Now, for both cases, the stmtid is 0, due memset to 0.
> src/pl/plpgsql/src/pl_gram.y:907
>
It was missing, fixed, thank you for check
Regards
Pavel
> --
> Peter Eisentraut http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
| Attachment | Content-Type | Size |
|---|---|---|
| plpgsql-statement-id-04.patch | text/x-patch | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-01-22 18:17:02 | Re: Refactoring the checkpointer's fsync request queue |
| Previous Message | Andres Freund | 2019-01-22 17:56:35 | Re: Thread-unsafe coding in ecpg |