| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Variable substitution in psql backtick expansion |
| Date: | 2017-11-10 14:49:28 |
| Message-ID: | CAFj8pRAGwaZnDPPt5WqKw8wjgGBYDw2Zss+wBf5P-Mb9w2-NWw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
I am sending a review of last patch psql-server-version-1.patch.gz
This patch is trivial - the most big problem is choosing correct name for
GUC. I am thinking so server_version_raw is acceptable.
I had to fix doc - see attached updated patch
All tests passed.
I'll mark this patch as ready for commiters
Regards
Pavel
| Attachment | Content-Type | Size |
|---|---|---|
| psql-server-version-2.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-10 15:09:37 | Re: [POC] Faster processing at Gather node |
| Previous Message | Peter Eisentraut | 2017-11-10 14:05:49 | Re: Add some const decorations to prototypes |