Re: Parallel bitmap heap scan

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel bitmap heap scan
Date: 2017-03-27 13:03:57
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On Mon, Mar 27, 2017 at 5:58 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Failing to pass DSA_ALLOC_HUGE is an obvious oversight, but I think
> the ptbase == NULL check shouldn't be needed, because we're not
> passing DSA_ALLOC_NO_OOM. And that's good, because this is going to
> be called from SH_CREATE, which isn't prepared for a NULL return
> anyway.
> Am I all wet?

Yes you are right that we are not passing DSA_ALLOC_NO_OOM, so
dsa_allocate_extended will return error in case if allocation failed.

Dilip Kumar

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-03-27 13:25:19 Re: [COMMITTERS] pgsql: Improve access to parallel query from procedural languages.
Previous Message Robert Haas 2017-03-27 12:54:24 Re: Monitoring roles patch