| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Date: | 2021-10-05 08:06:56 |
| Message-ID: | CAFiTN-v1KYsVAhq_fOWFa27LZiw9uK4n4cz5XmQJxJpsVcfq1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 4, 2021 at 2:51 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
I have implemented the patch with approach2 as well, i.e. instead of
scanning the pg-class, we scan the directory.
IMHO, we have already discussed most of the advantages and
disadvantages of both approaches so I don't want to mention those
again. But I have noticed one more issue with the approach2,
basically, if we scan the directory then we don't have any way to
identify the relation-OID and that is required in order to acquire the
relation lock before copying it, right?
Patch details:
0001 to 0006 implements an approach1
0007 removes the code of pg_class scanning and adds the directory scan.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Refactor-relmap-load-and-relmap-write-functions.patch | application/octet-stream | 7.9 KB |
| v5-0003-Refactor-index_copy_data.patch | application/octet-stream | 4.7 KB |
| v5-0004-Extend-bufmgr-interfaces.patch | application/octet-stream | 7.3 KB |
| v5-0005-New-interface-to-lock-relation-id.patch | application/octet-stream | 2.1 KB |
| v5-0002-Extend-relmap-interfaces.patch | application/octet-stream | 8.3 KB |
| v5-0006-WAL-logged-CREATE-DATABASE.patch | application/octet-stream | 28.9 KB |
| v5-0007-POC-WAL-LOG-CREATE-DATABASE-APPROACH-2.patch | application/octet-stream | 13.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-10-05 08:53:12 | Re: Duplicat-word typos in code comments |
| Previous Message | Daniel Gustafsson | 2021-10-05 07:41:08 | Re: plperl: update ppport.h and fix configure version check |