Re: Parallel bitmap heap scan

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel bitmap heap scan
Date: 2017-02-08 13:58:28
Message-ID: CAFiTN-u8UX-BMt=rkbnO0ZhjNeuJj7=mCfssq9y_e8QtkW0bOQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, Feb 8, 2017 at 7:01 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> You can store whatever you want in SH_TYPE's private_data member.
> SH_ALLOCATE and SH_FREE both get a pointer to the SH_TYPE, so they
> have access to that. Hmm, but there's no way to get that set in
> SH_CREATE before SH_ALLOCATE is called. Maybe we need to add a
> private_data argument to SH_CREATE. execGrouping.c could use that
> instead of frobbing private_data directly:
>
> - hashtable->hashtab = tuplehash_create(tablecxt, nbuckets);
> - hashtable->hashtab->private_data = hashtable;
> + hashtable->hashtab = tuplehash_create(tablecxt, nbuckets, hashtable);

Okay, will go ahead as you suggested. Patch attached for the same.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
hash_create_fix.patch application/octet-stream 2.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bernd Helmle 2017-02-08 14:00:36 Re: LWLock optimization for multicore Power machines
Previous Message Robert Haas 2017-02-08 13:44:16 Re: Parallel bitmap heap scan