Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Date: 2022-02-15 11:48:47
Message-ID: CAFiTN-u2ObGXFeST-A3ss9Ph_Gadzp=1c6-jac-LN5k5tc1UXg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 15, 2022 at 2:01 AM Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> wrote:
>
Here is the updated version of the patch, the changes are 1) Fixed
review comments given by Robert and one open comment from Ashutosh.
2) Preserved the old create db method. 3) As agreed upthread for now
we are using the new strategy only for createdb not for movedb so I
have removed the changes in ForgetDatabaseSyncRequests() and
DropDatabaseBuffers(). 3) Provided a database creation strategy
option as of now I have kept it as below.

CREATE DATABASE ... WITH (STRATEGY = WAL_LOG); -- default if
option is omitted
CREATE DATABASE ... WITH (STRATEGY = FILE_COPY);

I have updated the document but I was not sure how much internal
information to be exposed to the user so I will work on that based on
feedback from others.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v9-0001-Refactor-relmap-load-and-relmap-write-functions.patch text/x-patch 8.3 KB
v9-0005-New-interface-to-lock-relation-id.patch text/x-patch 2.2 KB
v9-0003-Refactor-index_copy_data.patch text/x-patch 5.3 KB
v9-0002-Extend-relmap-interfaces.patch text/x-patch 8.5 KB
v9-0004-Extend-bufmgr-interfaces.patch text/x-patch 4.2 KB
v9-0006-WAL-logged-CREATE-DATABASE.patch text/x-patch 34.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-02-15 11:52:00 Re: Ensure that STDERR is empty during connect_ok
Previous Message Joseph Koshakow 2022-02-15 11:44:40 Re: Fix overflow in DecodeInterval