Re: Proposal: scan key push down to heap [WIP]

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: scan key push down to heap [WIP]
Date: 2016-11-28 09:30:51
Message-ID: CAFiTN-u1z_mLuiBiOupbQAj_YXoQA3c3PMma3__nuBCZktGbhQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Sat, Nov 19, 2016 at 6:48 PM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> patch1: Original patch (heap_scankey_pushdown_v1.patch), only
> supported for fixed length datatype and use heap_getattr.
>
> patch2: Switches memory context in HeapKeyTest + Store tuple in slot
> and use slot_getattr instead of heap_getattr.
>
> patch3: call HeapKeyTest in SeqNext after storing slot, and also
> switch memory context before calling HeapKeyTest.
>
> I haven't yet tested patch3 with TPCH, I will do that once machine is available.

As promised, I have taken the performance with TPCH benchmark and
still result are quite good. However this are less compared to older
version (which was exposing expr ctx and slot to heap).

Query Head [1] Patch3 Improvement
Q3 36122.425 32285.608 10%
Q4 6797 5763.871 15%
Q10 17996.104 15878.505 11%
Q12 12399.651 9969.489 19%

[1] heap_scankey_pushdown_POC_V3.patch : attached with the mail.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
heap_scankey_pushdown_POC_V3.patch application/octet-stream 13.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2016-11-28 09:32:37 Re: Proposal: scan key push down to heap [WIP]
Previous Message Gilles Darold 2016-11-28 08:16:31 Re: [patch] psql tab completion for ALTER DEFAULT PRIVILEGES