| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Date: | 2021-12-02 13:49:50 |
| Message-ID: | CAFiTN-tcbQP05ae-bOw6rWwiyEmnNCd7-VXkCGz67dY87QsvLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 1, 2021 at 6:04 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> Thanks a lot for testing this. From the error, it seems like some of
> the old buffer w.r.t. the previous tablespace is not dropped after the
> movedb. Actually, we are calling DropDatabaseBuffers() after copying
> to a new tablespace and dropping all the buffers of this database
> w.r.t the old tablespace. But seems something is missing, I will
> reproduce this and try to fix it by tomorrow. I will also fix the
> other review comments raised by you in the previous mail.
Okay, I got the issue, basically we are dropping the database buffers
but not unregistering the existing sync request for database buffers
w.r.t old tablespace. Attached patch fixes that. I also had to extend
ForgetDatabaseSyncRequests so that we can delete the sync request of
the database for the particular tablespace so added another patch for
the same (0006).
I will test the performance scenario next week, which is suggested by John.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0003-Refactor-index_copy_data.patch | text/x-patch | 5.2 KB |
| v7-0004-Extend-bufmgr-interfaces.patch | text/x-patch | 7.2 KB |
| v7-0001-Refactor-relmap-load-and-relmap-write-functions.patch | text/x-patch | 7.9 KB |
| v7-0002-Extend-relmap-interfaces.patch | text/x-patch | 8.3 KB |
| v7-0005-New-interface-to-lock-relation-id.patch | text/x-patch | 2.2 KB |
| v7-0006-Extend-ForgetDatabaseSyncRequests-interface.patch | text/x-patch | 2.6 KB |
| v7-0007-WAL-logged-CREATE-DATABASE.patch | text/x-patch | 28.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2021-12-02 13:59:16 | Re: row filtering for logical replication |
| Previous Message | Amit Langote | 2021-12-02 13:48:08 | Re: pg_get_publication_tables() output duplicate relid |