Re: Gather performance analysis

On Sat, Aug 28, 2021 at 5:04 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>

>>
>> * mqh_partial_bytes, mqh_expected_bytes, and mqh_length_word_complete
>>
>> + Size mqh_send_pending;
>> bool mqh_length_word_complete;
>> bool mqh_counterparty_attached;
>>
>> I wonder if mqh_send_pending should be declared after mqh_length_word_complete - this way, the order of fields matches the order of explanation for the fields.

Moved it after mqh_consume_pending and moved comment as well in the
correct order.
>
> There was a typo in suggested code above. It should be:
>
> + if (force_flush || mqh->mqh_send_pending > (mq->mq_ring_size >> 2))

Done

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com