| From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Sequence Access Method WIP |
| Date: | 2016-04-04 13:53:13 |
| Message-ID: | CAFcNs+of-yp13AwXp7waP40O_9YFG8TqPLovKL-uVYkp+1jc3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 31, 2016 at 9:19 AM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>
> Hi,
>
> new version attached that should fix the issue. It was alignment -
honestly don't know what I was thinking using fixed alignment when the AMs
can define their own type.
>
Yeah... now all works fine... I had a minor issue when apply to the current
master but the attached fix it and I also added tab-complete support for
CREATE SEQUENCE...USING and ALTER SEQUENCE...USING.
I ran all the regression tests and all passed.
I have just one question about de 0002 patch:
- There are some reason to not use TransactionId instead of uint32 in
GaplessSequenceState struct?
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-seqam-2016-04-04.patch | text/x-diff | 168.4 KB |
| 0002-gapless-seq-2016-04-04.patch | text/x-diff | 27.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2016-04-04 14:02:19 | Re: Choosing parallel_degree |
| Previous Message | Amit Kapila | 2016-04-04 13:15:00 | Re: Updated backup APIs for non-exclusive backups |