Re: [PATCH] Preserve replication origin OIDs in pg_upgrade

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Rui Zhao <zhaorui126(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Preserve replication origin OIDs in pg_upgrade
Date: 2026-08-21 04:48:58
Message-ID: CAFPTHDbPXU7cs189J=BrzSa20EJzajOU25N7G7nT6UZqMkRnXg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 19, 2026 at 7:52 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Wed, Aug 19, 2026 at 11:13 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
> >
> > I have incorporated your comments and your changes in a new patch v16.
> >
>
> Please find a few minor comments:
>

I've addressed all the comments except the below one.

>
> 4)
>
> + old subscriber was up to. Migration of the subscription's replication
> + origin is supported for all cluster versions.
>
> Shall we say:
> all supported cluster versions

It is stating the obvious saying that it is supported for all
supported cluster versions, so I didn't change this.

regards,
Ajin Cherian
Fujitsu Australia

Attachment Content-Type Size
v17-0001-Preserve-subscription-OIDs-during-pg_upgrade.patch application/octet-stream 9.4 KB
v17-0002-Preserve-replication-origin-OIDs-during-pg_upgra.patch application/octet-stream 40.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Henson Choi 2026-08-21 04:52:33 Re: Row pattern recognition
Previous Message Michael Paquier 2026-08-21 04:45:35 Re: Fix small psql slash option leaks