| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2020-09-09 10:02:54 |
| Message-ID: | CAFPTHDawCH-Oy1YiLBWj9_S5cZ-T7kf474tbVhXjsJhmO+d0Yw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 7, 2020 at 11:17 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Nikhil has a test for the same
> (0004-Teach-test_decoding-plugin-to-work-with-2PC.Jan4) in his last
> email [1]. You might want to use it to test this behavior. I think you
> can also keep the tests as a separate patch as Nikhil had.
>
> Done. I've added the tests and also tweaked code to make sure that the
aborts during 2 phase commits are also handled.
>
> I don't know why the patch has used this way to implement an option to
> enable two-phase. Can't we use how we implement 'stream-changes'
> option in commit 7259736a6e? Just refer how we set ctx->streaming and
> you can use a similar way to set this parameter.
>
Done, I've moved the checks for callbacks to inside the corresponding
wrappers.
Regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Support-decoding-of-two-phase-transactions-at-PREPAR.patch | application/octet-stream | 63.4 KB |
| 0002-Tap-test-to-test-concurrent-aborts-during-2-phase-co.patch | application/octet-stream | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-09-09 10:23:40 | Re: Inconsistency in determining the timestamp of the db statfile. |
| Previous Message | Amit Kapila | 2020-09-09 09:50:32 | Re: Resetting spilled txn statistics in pg_stat_replication |