| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2020-11-19 05:57:10 |
| Message-ID: | CAFPTHDapBy+4z1ayPVMRtEYpDY+ZSa1qiqY8=0h_k-j7PzONsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Why did you make a change in stream_start API? I think it should be
> *_change and *_truncate APIs because the concurrent abort can happen
> while decoding any intermediate change. If you agree then you can
> probably take that code into a separate function and call it from the
> respective APIs.
>
Patch 0001:
Updated this from stream_start to stream_change. I haven't updated
*_truncate as the test case written for this does not include a
truncate.
Also created a new function for this: test_concurrent_aborts().
> In 0003,
> contrib/test_decoding/t/002_twophase-streaming.pl | 102 +++++++++
>
> The naming of the file seems to be inconsistent with other files. It
> should be 002_twophase_streaming.pl
Patch 0003:
Changed accordingly.
Patch 0002:
I've updated a comment that got muddled up while applying pg-indent in
reorderbuffer.c
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v22-0001-Support-2PC-txn-base.patch | application/octet-stream | 40.1 KB |
| v22-0002-Support-2PC-txn-backend.patch | application/octet-stream | 30.2 KB |
| v22-0004-Support-2PC-txn-spoolfile.patch | application/octet-stream | 3.9 KB |
| v22-0005-Support-2PC-txn-pgoutput.patch | application/octet-stream | 21.4 KB |
| v22-0003-Support-2PC-test-cases-for-test_decoding.patch | application/octet-stream | 37.5 KB |
| v22-0006-Support-2PC-txn-subscriber-tests.patch | application/octet-stream | 60.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-11-19 06:07:22 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Amit Kapila | 2020-11-19 05:49:42 | Re: [Patch] Optimize dropping of relation buffers using dlist |