Re: Support reset of Shared objects statistics in "pg_stat_reset" function

On Wed, Aug 11, 2021 at 10:30 AM Mahendra Singh Thalor
<mahi6run(at)gmail(dot)com> wrote:
>
> On Wed, 11 Aug 2021 at 09:17, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > On Tue, Aug 10, 2021 at 10:49 PM Mahendra Singh Thalor
> > <mahi6run(at)gmail(dot)com> wrote:
> >
> > > I checked this and found that we already have one process "stats
> > > collector" and in v02 patch, we are sending requests to collect stats
> > > two times. I don't know how costly one call is but I feel that we can
> > > avoid the 2nd call by keeping handling of the shared tables into
> > > pgstat_recv_resetcounter.
> > >
> >
> > I think let's not make the stat collector aware of what we want to
> > achieve, so the stat collector will only reset for what we have asked
> > for and let the caller or the signal sender decide what they want to
> > do.

If we do support resetting the stats for shared tables in
'pg_stat_reset', which is for DB level,
then the stats of shared tables will be reseted in other instances as
well, which seems to be not correct.
So we need to provide some way to reset the stats for shared tables to
customers.

In the latest patch, we have supported only through the
pgstat_recv_resetsinglecounter function to reset stats for shared
tables.

Thanks & Regards
SadhuPrasad
EnterpriseDB: http://www.enterprisedb.com