Re: build remaining Flex files standalone

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: build remaining Flex files standalone
Date: 2022-08-18 07:43:28
Message-ID: CAFBsxsHdAP0U3AjYuJ_SpWBxj2vmpdqXX3Yg=TLBrq0rAWhFgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > > > > index dbe7d4f742..0b373048b5 100644
> > > > > --- a/contrib/cube/cubedata.h
> > > > > +++ b/contrib/cube/cubedata.h
> > > > > @@ -67,3 +67,7 @@ extern void cube_scanner_finish(void);
> > > > >
> > > > > /* in cubeparse.y */
> > > > > extern int cube_yyparse(NDBOX **result);
> > > > > +
> > > > > +/* All grammar constructs return strings */
> > > > > +#define YYSTYPE char *
> > > >
> > > > Why does this need to be defined in a semi-public header? If we do this in
> > > > multiple files we'll end up with the danger of macro redefinition warnings.
>
> For v4, I #defined YYSTYPE

Sorry for the misfire. Continuing on, I #defined YYSTYPE in cubescan.l
before #including cubeparse.h.

I also added scanbuflen to the %parse-param to prevent resorting to a
global variable. The rest of the patches are unchanged.

--
John Naylor
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v4-0002-Move-private-declarations-shared-between-guc.c-an.patch text/x-patch 3.2 KB
v4-0001-Preparatory-refactoring-for-compiling-guc-file.c-.patch text/x-patch 26.0 KB
v4-0003-Build-guc-file.c-standalone.patch text/x-patch 2.5 KB
v4-0005-Build-repl_scanner.c-standalone.patch text/x-patch 6.1 KB
v4-0004-Build-bootscanner.c-standalone.patch text/x-patch 7.4 KB
v4-0008-Build-exprscan.c-standalone.patch text/x-patch 4.1 KB
v4-0006-Build-syncrep_scanner.c-standalone.patch text/x-patch 5.2 KB
v4-0009-Build-cubescan.c-standalone.patch text/x-patch 7.5 KB
v4-0010-Build-segscan.c-standalone.patch text/x-patch 4.5 KB
v4-0007-Build-specscanner.c-standalone.patch text/x-patch 5.3 KB
v4-0011-Build-jsonpath_scan.c-standalone.patch text/x-patch 7.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2022-08-18 08:00:03 Re: build remaining Flex files standalone
Previous Message John Naylor 2022-08-18 07:40:36 Re: build remaining Flex files standalone