Re: build remaining Flex files standalone

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: build remaining Flex files standalone
Date: 2022-08-13 08:39:06
Message-ID: CAFBsxsGq=jLMofR3BN1S1xJcaJsYcQnkWFRtRDObYVtDST0+Vg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here are the rest. Most of it was pretty straightforward, with the
main exception of jsonpath_scan.c, which is not quite finished. That
one passes tests but still has one compiler warning. I'm unsure how
much of what is there already is really necessary or was cargo-culted
from elsewhere without explanation. For starters, I'm not sure why the
grammar has a forward declaration of "union YYSTYPE". It's noteworthy
that it used to compile standalone, but with a bit more stuff, and
that was reverted in 550b9d26f80fa30. I can hack on it some more later
but I ran out of steam today.

Other questions thus far:

- "BISONFLAGS += -d" is now in every make file with a .y file -- can
we just force that everywhere?

- Include order seems to matter for the grammar's .h file. I didn't
test if that was the case every time, and after a few miscompiles just
always made it the last inclusion, but I'm wondering if we should keep
those inclusions outside %top{} and put it at the start of the next
%{} ?

- contrib/cubeparse.y now has a global variable -- not terrific, but I
wanted to get something working first.

- I'm actually okay with guc-file.c now, but I'll still welcome
comments on that.

--
John Naylor
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v201-0003-Build-repl_scanner.c-standalone.patch text/x-patch 4.1 KB
v201-0001-Build-guc-file.c-standalone.patch text/x-patch 27.5 KB
v201-0005-Build-specscanner.c-standalone.patch text/x-patch 4.5 KB
v201-0004-Build-syncrep_scanner.c-standalone.patch text/x-patch 3.5 KB
v201-0002-Build-booscanner.c-standalone.patch text/x-patch 5.8 KB
v201-0006-Build-cubescan.c-standalone.patch text/x-patch 5.1 KB
v201-0007-Build-segscan.c-standalone.patch text/x-patch 3.7 KB
v201-0008-Build-jsonpath_scan.c-standalone.patch text/x-patch 6.6 KB
v201-0009-Build-exprscan.c-standalone.patch text/x-patch 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-08-13 08:47:33 Re: Patch proposal: New hooks in the connection path
Previous Message Amit Kapila 2022-08-13 05:10:50 Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher