Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE

From: Jing Wang <jingwangian(at)gmail(dot)com>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE
Date: 2017-11-22 04:42:10
Message-ID: CAF3+xMLTyf8OCbeNQw9TnfWxNriAzLy+jy0+LY5LNj4JmYwUOQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi Nathan,

Thanks for review comments.

Enclosed please find the patch which has been updated according to your
suggestion.

The CURRENT_DATABASE can be used as following SQL statements and people can
find information from sgml files:
1. COMMENT ON DATABASE CURRENT_DATABASE is ...
2. ALTER DATABASE CURRENT_DATABASE OWNER to ...
3. ALTER DATABASE CURRENT_DATABASE SET parameter ...
4. ALTER DATABASE CURRENT_DATABASE RESET parameter ...
5. ALTER DATABASE CURRENT_DATABASE RESET ALL
6. SELECT CURRENT_DATABASE
7. SECURITY LABEL ON DATABASE CURRENT_DATABASE

As your mentioned the database_name are also present in the
GRANT/REVOKE/ALTER ROLE, so a patch will be present later for supporting
CURRENT_DATABASE on these SQL statements.

Regards,
Jing Wang
Fujitsu Australia

Attachment Content-Type Size
comment_on_current_database_no_pgdump_v4.4.patch application/octet-stream 35.5 KB
comment_on_current_database_for_pgdump_v4.4.patch application/octet-stream 4.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rushabh Lathia 2017-11-22 04:45:35 With commit 4e5fe9ad19, range partition missing handling for the NULL partition key
Previous Message Craig Ringer 2017-11-22 04:19:54 Re: [HACKERS] Issues with logical replication