| From: | solai v <solai(dot)cdac(at)gmail(dot)com> |
|---|---|
| To: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, vignesh C <vignesh21(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Vik Fearing <vik(at)postgresfriends(dot)org> |
| Subject: | Re: [PATCH] Add CANONICAL option to xmlserialize |
| Date: | 2026-10-21 06:32:16 |
| Message-ID: | CAF0whuf5smUnZToFMmpnisUt=WS2bpVcCmGpcfc+YVMFePSApQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 20, 2026 at 4:31 PM Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
>
> rebase
Hi Jim and all,
I tested the v28 patch for adding the xmlcanonicalize() function and
wanted to share my findings.
While building the patch, I encountered a compilation error in the
xml_parse() call because one argument was missing. I added the missing
argument locally, after which the build completed successfully.
I then tested the main functionality:
-XML attributes were sorted into canonical order.
-Empty elements were converted into explicit opening and closing tags.
-Equivalent XML documents produced the same canonical output.
-Comments were preserved by default and removed when keep_comments was
set to false.
-NULL input returned NULL.
All regression tests passed on my locally corrected version. I also
ran git diff --check, which completed without warnings after I
corrected the indentation.
Could you please check the xml_parse() call and update the patch accordingly?
Thanks for your work on this!
Regards,
solai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-10-21 06:37:10 | RE: 035_standby_logical_decoding might fail due to FATAL message lost inside libpq |
| Previous Message | Hannu Krosing | 2026-10-21 06:29:18 | [PATCH v1] Add automatic retry for autocommit statements on transient concurrency errors |