| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, David Christensen <david(at)pgguru(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improving btree performance through specializing by key shape, take 2 |
| Date: | 2024-02-01 14:49:13 |
| Message-ID: | CAEze2WhZUmCu5FmM+849OZuHEYO6hUmfUsMQn0mc80yXZq=6Zw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 27 Jan 2024 at 04:38, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> CFBot shows that the patch does not apply anymore as in [1]:
> === Applying patches on top of PostgreSQL commit ID
> 55627ba2d334ce98e1f5916354c46472d414bda6 ===
> === applying patch ./v14-0001-btree-Implement-dynamic-prefix-compression.patch
> ...
> Hunk #7 succeeded at 3169 with fuzz 2 (offset 75 lines).
> Hunk #8 succeeded at 3180 (offset 75 lines).
> Hunk #9 FAILED at 3157.
> Hunk #10 FAILED at 3180.
> Hunk #11 FAILED at 3218.
> 3 out of 11 hunks FAILED -- saving rejects to file
> contrib/amcheck/verify_nbtree.c.rej
>
> Please post an updated version for the same.
I've attached a rebased version, on top of HEAD @ 7b745d85. The
changes for prefix compression [0] and the rightsep+hikey optimization
[1] have been split off to separate patches/threads. I've also split
previous patch number 0003 into multiple parts, to clearly delineate
code movement vs modifications.
Kind regards,
Matthias van de Meent
Neon (https://neon.tech)
[0] https://commitfest.postgresql.org/46/4635/
[1] https://commitfest.postgresql.org/46/4638/
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0003-btree-Introduce-attribute-iterator-specializatio.patch | application/octet-stream | 14.6 KB |
| v15-0002-btree-Introduce-basic-specialization.patch | application/octet-stream | 22.6 KB |
| v15-0004-Add-an-attcacheoff-populating-function.patch | application/octet-stream | 4.8 KB |
| v15-0005-btree-Optimize-nbts_attiter-for-indexes-with-a-s.patch | application/octet-stream | 4.3 KB |
| v15-0001-btree-specialization-Prepare-code-for-specializa.patch | application/octet-stream | 236.5 KB |
| v15-0006-btree-Specialize-various-performance-sensitive-f.patch | application/octet-stream | 10.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-02-01 15:11:04 | Re: [PATCH] ltree hash functions |
| Previous Message | Heikki Linnakangas | 2024-02-01 13:54:23 | Re: Refactoring backend fork+exec code |