Re: Improvements and additions to COPY progress reporting

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improvements and additions to COPY progress reporting
Date: 2021-03-04 11:32:38
Message-ID: CAEze2WhQL_HBemwPA-D=icCsR7e+W0yKihwP_CoexSh=kGT8yg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 4 Mar 2021 at 11:38, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Mar 04, 2021 at 12:16:17PM +0530, Bharath Rupireddy wrote:
> > IMO, the phrasing proposed by Justin upthread looks good. It's like this:
> >
> > > + Each backend running <command>ANALYZE</command> will report its progress in
> > > + the <structname>pg_stat_progress_analyze</structname> view. See
>
> No objections to just go with that. As a new patch set is needed, I
> am switching the CF entry to "Waiting on Author".

Thanks for all your comments, and sorry for the delayed response.
Please find attached a new version of the patch set, that is rebased
and contains the requested changes:

1/3:
Docs:
- on which the COPY command is executed
+ on which the COPY command is being executed
Reworded existing commment:
- /* Increment amount of processed tuples and update the progress */
+ /* Increment the number of processed tuples, and report the progress */

2/3:
Docs:
- ... report its progress to ...
+ ... report its progress in ...
- report its progress to the >pg_stat_progress_cluster< ...
+ report its progress in the >pg_stat_progress_cluster< view ...

3/3:
No changes

I believe that that was the extent of the not-yet-resolved comments
and suggestions.

With regards,

Matthias van de Meent.

Attachment Content-Type Size
v11-0003-Add-copy-progress-reporting-regression-tests.patch text/x-patch 5.1 KB
v11-0002-Add-backlinks-to-progress-reporting-documentatio.patch text/x-patch 7.4 KB
v11-0001-Add-progress-reported-components-for-COPY-progre.patch text/x-patch 12.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-03-04 11:40:41 Re: Parallel INSERT (INTO ... SELECT ...)
Previous Message Ibrar Ahmed 2021-03-04 11:28:03 Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT