Re: Is the XLP_BKP_REMOVABLE flag itself removable/obsolete?

On Mon, 2 Mar 2026 at 06:20, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Feb 27, 2026 at 08:15:22AM +0900, Michael Paquier wrote:
> > Let's just remove this flag. I would have let XLP_ALL_FLAGS as it is
> > now at 0x000F, though. It is just used for filtering the bits we
> > allow to exist in this area of the header, for validation. Perhaps
> > some forks like this extensibility if they have their own extra custom
> > bits, meaning less code to modify. That's a minor point for sure, but
> > people like hacking on Postgres and forking this code.
>
> Done. The patch missed a variable declaration not required anymore in
> AdvanceXLInsertBuffer(), that I have caught with a compiler warning.

Thanks for the check, clean up, and commit!

Kind regards,

Matthias van de Meent
Databricks (https://www.databricks.com)